Skip to content

add JSON & TypeScript-Definitions #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 24, 2019
Merged

add JSON & TypeScript-Definitions #11

merged 7 commits into from
Oct 24, 2019

Conversation

MrSpoocy
Copy link
Contributor

@MrSpoocy MrSpoocy commented Oct 1, 2019

Simple add JSON from https://github.com/douglascrockford/JSON-js.

I also ask about TypeScript definition file (adobe-extension-tools/extendscript-es5-shim-ts#1). We don't need 100 repository if everyone need the same :) Maybe i create own TS file the simple copy from https://github.com/DefinitelyTyped/DefinitelyTyped and make a pull request.

@ff6347
Copy link
Member

ff6347 commented Oct 2, 2019

Maybe i create own TS file the simple copy from DefinitelyTyped/DefinitelyTyped and make a pull request.

PRs are always welcome

@MrSpoocy
Copy link
Contributor Author

MrSpoocy commented Oct 7, 2019

This is already is PR for JSON support xD You can merge it after review.

@ff6347
Copy link
Member

ff6347 commented Oct 7, 2019

Thank you. I’m currently not in the reach of a computer. Will be back in two weeks. Then I can do a review

@MrSpoocy
Copy link
Contributor Author

MrSpoocy commented Oct 7, 2019 •
edited
Loading

i simple copy & past the TypeScript Definition from Microsoft but only the function from the folders (include the Apache license header). Also update the Build script & the package.json.

The bundle file contains only one times the license header ;)

@MrSpoocy MrSpoocy changed the title add JSON add JSON & TypeScript-Definitions Oct 7, 2019
@lumenn
Copy link
Member

lumenn commented Oct 23, 2019

@fabianmoronzirfas
I'll be glad if you could check this PR, also users of extendscriptr would be able to benefit from this typescript definitions, and also JSON :)

@ff6347
Copy link
Member

ff6347 commented Oct 24, 2019 •
edited
Loading

@lumenn Yes I will. It's on the todo pile. Sorry for the delay.
If you are invested in this would you like to become a contributor on Extendscript org and on the Extendscriptr repo?

@lumenn
Copy link
Member

lumenn commented Oct 24, 2019

@fabianmoronzirfas
I thought that you could just forgot about this PR, as you were off.

About joining the org I'll be glad to join, as i'm currently doing a lot of Illustrator scripting, so hopefully I'll add something for everyone :)

@ff6347
Copy link
Member

ff6347 commented Oct 24, 2019 •
edited
Loading

@lumenn invite is on its way. You should have access to the shims repos and to extendscriptr. Let me know if you need more. See https://github.com/ExtendScript

@ff6347 ff6347 requested a review from a team October 24, 2019 08:47
lumenn
lumenn reviewed Oct 24, 2019
View reviewed changes
Copy link
Member

@lumenn lumenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In bin/concat.js i see there is change from 2 space tab to 4 space tab, also some comments (used for debugging purposes i suppose) were removed.

Everything else seems fine for me, should we also increase version ?

@lumenn lumenn merged commit 41fce82 into ExtendScript:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumenn lumenn lumenn left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrSpoocy @ff6347 @lumenn